RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v22]

Carl Christian Snethlage duke at openjdk.org
Thu Apr 25 20:22:52 UTC 2024


On Thu, 25 Apr 2024 19:39:02 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>> 
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then an addition of `start` to it leads to a negative value. This is "fixed" by using `Math.max` comparing the `maxLength` and `maxLength + start`.
>
> Oliver Kopp has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 30 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into patch-1
>  - Switch from `@EnabledOnOS` to `assumeTrue`
>  - Re-order for more clearness
>  - Fix tests
>  - Remove unused import
>  - classpath
>  - Fix JavaDoc formatting
>  - Discard changes to modules/javafx.graphics/src/test/addExports
>  - Add missing exports
>  - Try to use StubToolkit
>  - ... and 20 more: https://git.openjdk.org/jfx/compare/a7c1c59f...527e1ecf

Tried on my local machine (win10) w/o patch with narrator:
![grafik](https://github.com/openjdk/jfx/assets/50491877/6603c29b-8f65-41d5-afe9-8db3eaf2fc75)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2078090611


More information about the openjfx-dev mailing list