RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]

Oliver Kopp duke at openjdk.org
Mon Apr 29 15:50:15 UTC 2024


On Mon, 29 Apr 2024 14:09:52 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Oliver Kopp has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert using utility method
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java line 104:
> 
>> 102:         int length = text.length();
>> 103:         start = Utils.clamp(0, start, length);
>> 104:         end = Utils.clamp(start, end, length);
> 
> This is only cleanup and not required for this fix.

I applied the software engineering principle to leave the code cleaner than seen. (Martin Fowler et all) 

Should I revert this?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1583314511


More information about the openjfx-dev mailing list