RFR: 8325445: [macOS] Colors are not displayed in sRGB color space [v4]

[Martin Fox]

On Thu, 1 Aug 2024 17:42:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated comments concerning the AWT Robot
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassRobot.m line 423:
> 
>> 421:                         components[1] = (CGFloat)((color & 0x0000FF00) >> 8) / 255.0;
>> 422:                         components[2] = (CGFloat)((color & 0x000000FF)) / 255.0;
>> 423:                         components[3] = (CGFloat)((color & 0xFF000000) >> 24) / 255.0;
> 
> is this line guaranteed not to produce negative values?  e.g. when `color = 0xffffffff`

Good catch. I've updated the code to read the pixel value into an unsigned integer.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1473#discussion_r1700742971