RFR: 8332895: Support interpolation for backgrounds and borders [v2]
Michael Strauß
mstrauss at openjdk.org
Fri Aug 2 01:39:12 UTC 2024
On Thu, 1 Aug 2024 23:36:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed a bug
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderConverter.java line 270:
>
>> 268: case ROUND -> BackgroundRepeat.ROUND;
>> 269: case SPACE -> BackgroundRepeat.SPACE;
>> 270: case STRETCH -> BackgroundRepeat.NO_REPEAT;
>
> what do you think of adding default: case?
> this code will not compile if BorderRepeat ever acquires a new value.
Yes, I think that's good, as it will alert us to the impact of adding a new enum value. We would probably need to account for the new value here (there's no good default we can choose).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1701073308
More information about the openjfx-dev
mailing list