RFR: 8336389: Infinite loop occurs while resolving lookups [v7]

[Andy Goryachev]

On Fri, 2 Aug 2024 15:02:13 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Fixes an infinite loop that can occur while resolving lookups.
>> 
>> There were 2 bugs:
>> - A `contains` check was done on some value X, but then a value Y was added to the set used to track duplicates
>> - The `Set` to track duplicates was cleared in some recursive calls, meaning that the caller (which may be processing multiple values in a loop) would end up with an empty set, losing track of what was visited so far
>> 
>> Also removed a redundant `null` check (an NPE would have occurred before it could reach that code).
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update CssStyleHelper.java

re-tested on macOS, works as expected.

also tested in the Monkey Tester with the CSS provided in the ticket (errors appear in stderr as expected), and after the offending CSS is removed (gets back to normal).

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1505#pullrequestreview-2216111787