RFR: 8337281: build.gradle assumes all modules are named "javafx.$project" [v2]

Kevin Rushforth kcr at openjdk.org
Fri Aug 2 20:15:39 UTC 2024


On Mon, 29 Jul 2024 23:11:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bug where String was being used as if it were a Project
>
> build.gradle line 970:
> 
>> 968: 
>> 969:     if (HAS_JAVAFX_MODULES) {
>> 970:         List<String> modsWithNative = [ 'javafx.graphics', 'javafx.media', 'javafx.web' ]
> 
> very minor: maybe one entry per line?

I'd prefer not to at this point.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1518#discussion_r1702279337


More information about the openjfx-dev mailing list