Integrated: 8336389: Infinite loop occurs while resolving lookups
John Hendrikx
jhendrikx at openjdk.org
Sun Aug 4 23:12:39 UTC 2024
On Mon, 15 Jul 2024 13:21:53 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> Fixes an infinite loop that can occur while resolving lookups.
>
> There were 2 bugs:
> - A `contains` check was done on some value X, but then a value Y was added to the set used to track duplicates
> - The `Set` to track duplicates was cleared in some recursive calls, meaning that the caller (which may be processing multiple values in a loop) would end up with an empty set, losing track of what was visited so far
>
> Also removed a redundant `null` check (an NPE would have occurred before it could reach that code).
This pull request has now been integrated.
Changeset: f7ad5cdc
Author: John Hendrikx <jhendrikx at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/f7ad5cdccb03162dc19fffb8eed570d4fbef490c
Stats: 171 lines in 2 files changed: 158 ins; 9 del; 4 mod
8336389: Infinite loop occurs while resolving lookups
Reviewed-by: angorya, kcr
-------------
PR: https://git.openjdk.org/jfx/pull/1505
More information about the openjfx-dev
mailing list