RFR: 8325445: [macOS] Colors are not displayed in sRGB color space [v5]

Andy Goryachev angorya at openjdk.org
Mon Aug 5 16:19:40 UTC 2024


On Mon, 5 Aug 2024 16:10:33 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I don't see any way to query whether we're running under Wayland or not. That would be nice to have.
>> 
>> This is the only test that uses the AWT Robot on Linux. The window background test also uses the AWT Robot but only runs on Mac.
>
> @alexeysemenyukoracle added an [`isOnWayland`](https://github.com/openjdk/jfx/blob/jfx23/tests/system/src/test/java/test/robot/javafx/embed/swing/SwingNodeBase.java#L194) method to `SwingNodeBase.java`. I'll file a new testbug to skip tests that use AWT Robot on Wayland pending the fix for [JDK-8335468](https://bugs.openjdk.org/browse/JDK-8335468). As part of that, we can move `isOnWayland` to [`Util.java`](https://github.com/openjdk/jfx/blob/jfx23/tests/system/src/test/java/test/util/Util.java) (and fix it to first check `PlatformUtil::isLinux`).

maybe we ought to fast track an isolated addition of `isOnWayland()` and integrate that first?  what do you think?

edit: never mind, this PR is already integrated.  aren't we supposed to wait 24 hrs before integrating?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1473#discussion_r1704358262


More information about the openjfx-dev mailing list