RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

Lukasz Kostyra lkostyra at openjdk.org
Tue Aug 6 12:55:43 UTC 2024


On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Specific to KDE, in the case of the example provided, when an MODAL window pops, it calls `set_enabled` `false` on the child (or all other windows if APPLICATION_MODAL) which causes it to update the window constraints. When maximized, the constraints where applied anyways, causing the window to still be maximized but not show as maximized. The change is to not apply constraints when not floating (meaning floating on the screen - not maximized, fullscreen or iconified).
>> 
>> It's not specific to DEBIAN, it depends on the window manager (kwin is affected).
>
> Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert idea file
>  - Fix only the original bug

LGTM. I confirmed it works on latest Ubuntu 23.04 with KDE Plasma. Gnome behavior is unchanged (correct and KDE matches Gnome behavior).

-------------

Marked as reviewed by lkostyra (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1460#pullrequestreview-2221218851


More information about the openjfx-dev mailing list