RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

[John Hendrikx]

On Tue, 6 Aug 2024 22:43:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I can see if I can externalize this or if that would run into issues.  Also please note, although technically an API change, it is NOT an accessible API (and so can be removed at any time) because only the permitted types can access this API.
>> 
>> In other words, this could wait and be done separately or never.
>
> what is the resolution, @hjohn ?

- I've moved the serialization logic to `BinarySerializer` and removed the two methods from `Selector`.  `writeBinary` was `protected` but couldn't be accessed before anyway as it was impossible to subclass `Selector` (as it had a package private constructor)
- I've moved most of the code to create a `Match` to the `Match` class so the relevant fields can now be `private`. 

Let me know if this is an improvement.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1706292988