RFR: 8332895: Support interpolation for backgrounds and borders [v18]

Andy Goryachev angorya at openjdk.org
Wed Aug 7 15:23:42 UTC 2024


On Wed, 7 Aug 2024 15:08:30 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java line 108:
>> 
>>> 106:     public @interface SupportsReconstruction {}
>>> 107: 
>>> 108:     final boolean supportsReconstruction;
>> 
>> would it be easier just to pass a boolean to the constructor?
>> we are changing the public API anyway...
>> 
>> also: since the boolean is package protected, should we have a (short) javadoc for it?
>
>> would it be easier just to pass a boolean to the constructor? we are changing the public API anyway...
> 
> Usually boolean parameters are not a good API choice, but I have no strong opinion on this one. What do you prefer?

I just think it's much simpler than an annotation...

Or it could be a public instance method `boolean isSupportReconstruction()` for the child classes to override, saving N (1? 8?) bytes per instance.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1707228516


More information about the openjfx-dev mailing list