RFR: 8333919: dragViewOffsetX/dragViewOffsetY are ignored for the dragView image [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Fri Aug 9 08:13:16 UTC 2024
> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset calculation was left out, which made Dragboard offset API not work on macOS.
>
> This change fixes this mistake. Now drag image should be properly offset.
Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
GlassViewDelegate: Correctly set origin and offset in dragImage
- Centering to dragImage was removed - origin is now top-left of dragImage
- Offset direction was swapped
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1532/files
- new: https://git.openjdk.org/jfx/pull/1532/files/92c190e2..c922de84
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1532&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1532&range=00-01
Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod
Patch: https://git.openjdk.org/jfx/pull/1532.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1532/head:pull/1532
PR: https://git.openjdk.org/jfx/pull/1532
More information about the openjfx-dev
mailing list