RFR: 8334900: IOOBE when adding data to a Series of a BarChart that already contains data [v3]

[Markus Mack]

On Mon, 15 Jul 2024 16:32:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Markus Mack has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix "negative" style class when series is changed
>
> modules/javafx.controls/src/test/java/test/javafx/scene/chart/BarChartTest.java line 305:
> 
>> 303:         BarChart<String, Number> chart = new BarChart<>(new CategoryAxis(), new NumberAxis());
>> 304:         XYChart.Series<String, Number> series = new XYChart.Series<>();
>> 305:         chart.getData().add(series);
> 
> speaking of negative values - could we check **all** the possible ways where the 'negative' class is added?  or removed?
> 
> I think it might be possible to add a check to the exiting tests, to reuse the setup.
> 
> Lastly, I think we also need to test the case when the data point becomes non-negative after explicit XYChart.Data.setValue(), do you think?

good idea, done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1488#discussion_r1712669740