RFR: 8333919: dragViewOffsetX/dragViewOffsetY are ignored for the dragView image [v3]

[Jose Pereda]

On Mon, 12 Aug 2024 12:58:25 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset calculation was left out, which made Dragboard offset API not work on macOS.
>> 
>> This change fixes this mistake. Now drag image should be properly offset.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust clamping values, remove old TODO

Looking good, I still have two minor comments

modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line 1049:

> 1047:         if (image != nil)
> 1048:         {
> 1049:             // select the center of the image as the drag origin

There are two consecutive `if (image != nil)` blocks, so you can remove the 4 lines above this one.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1532#pullrequestreview-2233475851
PR Review Comment: https://git.openjdk.org/jfx/pull/1532#discussion_r1714048165