RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

[Kevin Rushforth]

On Mon, 12 Aug 2024 20:41:13 GMT, Phil Race <prr at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> buildSrc/win.gradle line 93:
> 
>> 91:         defineProperty("WINDOWS_VS_LIB", properties, "$WINDOWS_VS_VCINSTALLDIR/LIB;" + "$WINDOWS_SDK_DIR/lib;")
>> 92:         defineProperty("WINDOWS_VS_LIBPATH", properties, "$WINDOWS_VS_VCINSTALLDIR/LIB;")
>> 93:         def parfaitPath = IS_COMPILE_PARFAIT ? System.getenv().get("PARFAIT_PATH") + ";" : "";
> 
> Did you mean to remove parfaitPath ?

Yes, it was intentional. Once I removed the (unused) default for `WINDOWS_VS_PATH`, that local variable was no longer referenced.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714383497