RFR: 8333919: [macOS] dragViewOffsetX/dragViewOffsetY are ignored for the dragView image [v4]
Kevin Rushforth
kcr at openjdk.org
Mon Aug 12 22:50:54 UTC 2024
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset calculation was left out, which made Dragboard offset API not work on macOS.
>>
>> This change fixes this mistake. Now drag image should be properly offset.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>
> Merge two if image != nil statements together
>
> Those were unnecessarily split
Looks good to me. Unifying the behavior on Windows and Linux can be done in the follow-up bug [JDK-8338204](https://bugs.openjdk.org/browse/JDK-8338204).
If needed, additional follow-up issues can be filed.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1532#pullrequestreview-2234132296
More information about the openjfx-dev
mailing list