RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

John Hendrikx jhendrikx at openjdk.org
Tue Aug 13 12:07:58 UTC 2024


On Tue, 13 Aug 2024 12:05:18 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/css/Match.java line 90:
>> 
>>> 88:     private final int specificity;
>>> 89: 
>>> 90:     @SuppressWarnings("removal")
>> 
>> What is this removal warning suppression? I know it was there before these changes.
>
> `SimpleSelector` was deprecated for removal (from the public javafx.css package). Now that it is moved to the internal package, the deprecation on that was also removed.  The `SuppressWarnings` is therefore no longer needed here as the deprecation is no longer present on the now internal `SimpleSelector` type.

The diff seems to show I did not remove that line, but it should no longer be needed.  I'll check.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1715180851


More information about the openjfx-dev mailing list