RFR: 8336938: Update libFFI to 3.4.6

Kevin Rushforth kcr at openjdk.org
Tue Aug 13 12:34:52 UTC 2024


On Tue, 13 Aug 2024 01:03:32 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> Yes, it compiles fine. It was changed by libFFI itself in 3.4.6. I think to be inline with rest of comments in this file.

What I meant was that you missed making that change when you updated the file. The old line with the inline comment style is still in our copy of the file. So it no longer matches the upstream libffi 3.4.6. It seems best to apply that part of the patch so that we will match the upstream version of the file.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1531#issuecomment-2286144930


More information about the openjfx-dev mailing list