RFR: 8337246: SpinnerSkin does not consume ENTER KeyEvent when editor ActionEvent is consumed [v2]

Andy Goryachev angorya at openjdk.org
Tue Aug 13 21:42:56 UTC 2024


On Tue, 13 Aug 2024 21:35:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Enable backpropagation of `isConsumed` flag to the ancestor(s) of events cloned via `Event.copyFor()`.
>> 
>> This change has a minimal API impact and allows for a fine-grained control of when to propagate and when not to propagate.
>> 
>> The proposed change could make [JDK-8303209](https://bugs.openjdk.org/browse/JDK-8303209) unnecessary.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - avoid csr
>  - Merge remote-tracking branch 'origin/master' into ag.consume
>  - only if consumed
>  - only when consumed
>  - propagate
>  - cleanup
>  - simpler
>  - event helper
>  - copy for test
>  - propagate consume action

Removed 'final' keyword from existing public APIs.

The changes are limited to TextFieldBehavior and SpinnerSkin.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1523#issuecomment-2287183307


More information about the openjfx-dev mailing list