RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v2]

[Kevin Rushforth]

On Tue, 13 Aug 2024 06:27:51 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Thanks, that would be helpful. Let me know what you find.
>
> I checked on a Win 11 system where Build Tools 2022 are installed in default directory (no other Visual Studio edition) and the build failed with "Cannot locate Visual Studio compilers" message. Adding `BuildTools` as an option to this loop fixed it and JFX built properly (checked without Media and Webkit). Alternatively, setting `VSCOMMONTOOLS` also helps, but I think we can easily add `BuildTools` as an option here.
> 
> As a side-note - building without this PR on the same system also failed so it doesn't necessarily introduce a regression, but I think it would be a worthy addition regardless.

I decided to go ahead and add this. Can you test and review it?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1716227825