RFR: 8337246: SpinnerSkin does not consume ENTER KeyEvent when editor ActionEvent is consumed

Martin Fox mfox at openjdk.org
Wed Aug 14 16:57:58 UTC 2024


On Wed, 14 Aug 2024 15:15:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> But this PR does not link the two events generally, but addresses one specific scenario.

The event is being fired which means it may pass through any number of dispatchers some of which may be written by outside developers.

> As I mentioned earlier, this is the problem of the dispatcher. Anyone can fire an event.

There are rules for how a dispatcher works. A dispatcher that follows those rules can still break this PR. This suggests that the problem is with the PR and not the dispatcher. And there is a way to write this PR that works with the existing rules governing dispatchers.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1523#issuecomment-2289315066


More information about the openjfx-dev mailing list