RFR: 8338016: SplitMenuButton constructors should match MenuButton

Michael Strauß mstrauss at openjdk.org
Wed Aug 14 17:25:06 UTC 2024


On Tue, 13 Aug 2024 22:27:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Adding SplitMenuButton constructors matching MenuButton:
> 
> - public SplitMenuButton(String text)
> - public SplitMenuButton(String text, Node graphic)
> - public SplitMenuButton(String text, Node graphic, MenuItem... items)

modules/javafx.controls/src/main/java/javafx/scene/control/SplitMenuButton.java line 123:

> 121:      * @param text the text to display on the menu button
> 122:      * @param graphic the graphic to display on the menu button
> 123:      * @param items The items to display in the popup menu.

Minor: description should start with a small letter and not end with a dot.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1717226223


More information about the openjfx-dev mailing list