RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

Martin Fox mfox at openjdk.org
Mon Aug 19 17:42:00 UTC 2024


On Mon, 19 Aug 2024 16:32:31 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Interesting. I just did a quick test on the Mac and verified that either coordinate can go negative. There must be a difference in the way the platform's model multiple monitors.
>
> on mac and windows the coordinates can be negative, depending on the screen arrangement.
> 
> why do we need to rely on the fact that `pos[]` values are positive anyway?

I was able to set up a multiple monitor system. Linux does work differently than Mac or Windows but the X coordinate returned by View can still be negative if the window is partially off the left edge of the leftmost screen. But in that case the Window's X coordinate will also be negative so subtracting it out will generate the correct widget-relative location. So I suggest removing the conditional checks here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1722137039


More information about the openjfx-dev mailing list