RFR: 8336940: Update GStreamer to 1.24.6

Kevin Rushforth kcr at openjdk.org
Wed Aug 21 21:18:56 UTC 2024


On Wed, 21 Aug 2024 20:15:00 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Updated GStreamer to 1.24.6 and Glib to 2.80.4.
> - Testing done on all platforms with all supported formats.
> - Removed gstpluginloader.c. This file contains additional plugin loading mechanism which we do not use. Latest GStreamer modified it heavily and it did not compile without pulling additional dependency from GLib, but since we do not use it anyway it was removed. Corresponding calls to gstpluginloader.c from gstregistry.c were disabled as well.
> - Removed DSD support from Alsa audio sink. Latest GStreamer added support for Alsa DSD (Direct Stream Digital), but we do not use it so it was removed. Also, such support requires newer libasound2 (ALSA) which is not available on older Linux distributions.
> - No other changes or bug fixes are done.

Reviewers: @kevinrushforth and @tiainen or @johanvos

I get a compilation error on my admittedly too-old Ubuntu 16.04 system. It might be worth adding the missing header file, in case other distros hit the same problem.


In file included from ../../../gstreamer-lite/gstreamer/gst/gstmeta.h:28,
                 from ../../../gstreamer-lite/gstreamer/gst/gstbuffer.h:43,
                 from ../../../gstreamer-lite/gstreamer/gst/gstpad.h:70,
                 from ../../../gstreamer-lite/gstreamer/gst/gstelement.h:223,
                 from ../../../gstreamer-lite/gstreamer/gst/gstbin.h:27,
                 from ../../../gstreamer-lite/gstreamer/gst/gst.h:35,
                 from ../../../gstreamer-lite/gstreamer/libs/gst/base/gstbitreader.h:24,
                 from ../../../gstreamer-lite/gstreamer/libs/gst/base/gstbitreader.c:26:
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h: In function 'gst_byte_array_interface_init':
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:66:3: error: implicit declaration of function 'memset' [-Werror=implicit-function-declaration]
   66 |   memset (self, 0, sizeof (GstByteArrayInterface));
      |   ^~~~~~
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:1:1: note: include '<string.h>' or provide a declaration of 'memset'
  +++ |+#include <string.h>
    1 | /* Copyright (C) 2023 Netflix Inc.
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:66:3: warning: incompatible implicit declaration of built-in function 'memset' [-Wbuiltin-declaration-mismatch]
   66 |   memset (self, 0, sizeof (GstByteArrayInterface));
      |   ^~~~~~
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:66:3: note: include '<string.h>' or provide a declaration of 'memset'
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h: In function 'gst_byte_array_interface_append_data':
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:125:3: error: implicit declaration of function 'memcpy' [-Werror=implicit-function-declaration]
  125 |   memcpy (ptr, data, size);
      |   ^~~~~~
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:125:3: note: include '<string.h>' or provide a declaration of 'memcpy'
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:125:3: warning: incompatible implicit declaration of built-in function 'memcpy' [-Wbuiltin-declaration-mismatch]
../../../gstreamer-lite/gstreamer/gst/gstbytearrayinterface.h:125:3: note: include '<string.h>' or provide a declaration of 'memcpy'
cc1: some warnings being treated as errors
Makefile:281: recipe for target 'modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gstreamer/libs/gst/base/gstbitreader.o' failed
make: *** [modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gstreamer/libs/gst/base/gstbitreader.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory 'modules/javafx.media/src/main/native/gstreamer/projects/linux/gstreamer-lite'

> Task :media:buildLinuxGStreamer FAILED

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1542#issuecomment-2302940315
PR Comment: https://git.openjdk.org/jfx/pull/1542#issuecomment-2302994966


More information about the openjfx-dev mailing list