RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64 [v2]

Kevin Rushforth kcr at openjdk.org
Thu Aug 29 17:11:23 UTC 2024


On Thu, 29 Aug 2024 14:43:39 GMT, ANUPAM DEV <duke at openjdk.org> wrote:

>> Hi,
>> 
>> I have updated the name of the SWT.jar that needs to be downloaded during the build process for Linux aarch64.
>> from:
>>     IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : ""
>> 
>> to:
>>     IS_LINUX && IS_AARCH64 ? "org.eclipse.swt.gtk.linux.aarch64_3.124.200.v20231113-1355" :
>>     IS_LINUX && !IS_AARCH64 ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : ""
>> 
>> Please review.
>> 
>> Regards,
>> Anupam
>
> ANUPAM DEV has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated verification-metadata.xml. Added sha256 for Linux /aarch64 jar

I pulled the PR branch, then locally edited `build.gradle` to download the new linux_aarch64 artifact on the platform I was building on (it happened to be Windows, but whatever platform you have will work). It worked, meaning the entry you added to `gradle/verification.xml` was good.

Btw, I filed the following bug to add a GHA build for Linux / aarch64, similar to what I recently did for macOS / aarch64:

[JDK-8339270](https://bugs.openjdk.org/browse/JDK-8339270): GHA: build on Linux / aarch64

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1549#pullrequestreview-2269557474


More information about the openjfx-dev mailing list