RFR: 8337481: File API: file.name contains path instead of name [v2]
Oliver Schmidtmer
duke at openjdk.org
Fri Aug 30 11:38:29 UTC 2024
On Fri, 30 Aug 2024 08:18:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add test
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/FileTest.java line 94:
>
>> 92: });
>> 93: }
>> 94: }
>
> The test requires a few changes:
> 1. Correct copyright year
> 2. Several imports can be removed.
> 3. method `private State getLoadState()` is unused
> 4. method `getScriptString()` can be replaced with a string member variable
> 5. Line 70,71 needs format correction
>
> I tried these changes locally, attaching the file with required changes. Please check
> [FileTest.java.zip](https://github.com/user-attachments/files/16813919/FileTest.java.zip)
I have taken the requested changes from your file.
This was simply taken from test.javafx.scene.web.FileReaderTest with future tests for other file properties in mind.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1551#discussion_r1738468124
More information about the openjfx-dev
mailing list