RFR: 8309381: Support JavaFX incubator modules [v3]

[Andy Goryachev]

On Mon, 2 Dec 2024 17:04:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> build.gradle line 2877:
>> 
>>> 2875: // Add a project declaration for each incubator module here, leaving the
>>> 2876: // incubator placeholder lines as an example.
>>> 2877: // BEGIN: incubator placeholder
>> 
>> Q: maybe we should mention the JBS every time we say the word "incubator"?
>> 
>> It might be useful to anyone who is looking at the code and has no access to git history (or when git history is obscured by a move).  I mean, JBS is our knowledge base, and it usually helps.
>
> I generally prefer not to do this. In this case, the JBS Enhancement isn't what we would want to point to anyway (it would just be a placeholder). I can see some value in pointing to the CSR, so I'll add that here (I don't think there a need to repeat it).
> 
> What would really be useful, though, is a pointer to a template with a sample module, along the lines of what I mentioned in #1617, and a pointer to the JEP (which gets back to an earlier discussion of a permanent repository for JEPs). I'll file a follow-up issue to address this.

thank you, the CSR is definitely better.

Referring to a ticket has another positive side effect: it's easy to grep.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1866286281