RFR: 8345261: Refactor the Dimension2D classes

Nir Lisker nlisker at openjdk.org
Mon Dec 2 20:21:43 UTC 2024


On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> A small refactoring of the Dimension classes.
> 
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Dimension2D`: fields became `final`.
> 
> I'm not sure we need the implementation class at all considering we are free to use the public one.

You reviewed the PR before the requested changes were made :)
I'm going to move the `int` one into an inner class anyway.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2512712866


More information about the openjfx-dev mailing list