RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v4]

Kevin Rushforth kcr at openjdk.org
Mon Dec 2 21:28:42 UTC 2024


On Mon, 2 Dec 2024 21:14:18 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> The bug happened when setting only width or height (not both) on a Stage that was oriented by the view size.
>> 
>> The fix just uses the previous value for width/height if not set.
>> 
>> The test class is designed to accept more test cases in the "mixed sizing" scenarios.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add sleep to avoid intermittent failures

tests/system/src/test/java/test/javafx/stage/StageMixedSizeTest.java line 103:

> 101: 
> 102:             mainStage.setOnShown(e -> {
> 103:                 Util.sleep(500);

We don't want to sleep on the FX application thread. I think you'll need to split this into separate `Runnable`s for separate calls to `Util::runAndWait` and have the sleeps between them.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1654#discussion_r1866640776


More information about the openjfx-dev mailing list