RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v3]

Kevin Rushforth kcr at openjdk.org
Mon Dec 2 21:28:44 UTC 2024


On Sat, 30 Nov 2024 16:14:22 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> The bug happened when setting only width or height (not both) on a Stage that was oriented by the view size.
>> 
>> The fix just uses the previous value for width/height if not set.
>> 
>> The test class is designed to accept more test cases in the "mixed sizing" scenarios.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test package

tests/system/src/test/java/test/javafx/stage/StageMixedSizeTest.java line 111:

> 109: 
> 110:         Util.waitForLatch(showLatch, 5, "Stage failed to setup and show");
> 111:         Util.sleep(500);

This sleep was already in the right place... on the test thread after the latch is triggered.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1654#discussion_r1866641774


More information about the openjfx-dev mailing list