RFR: 8301121: RichTextArea Control (Incubator) [v50]

[Ambarish Rapte]

On Fri, 22 Nov 2024 18:07:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Incubating a new feature - rich text control, **RichTextArea**, intended to bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The main design goal is to provide a control that is complete enough to be useful out-of-the box, as well as open to extension by the application developers.
>> 
>> This is a complex feature with a large API surface that would be nearly impossible to get right the first time, even after an extensive review. We are, therefore, introducing this in an incubating module, **jfx.incubator.richtext**. This will allow us to evolve the API in future releases without the strict compatibility constraints that other JavaFX modules have.
>> 
>> Please check out two manual test applications - one for RichTextArea (**RichTextAreaDemoApp**) and one for the CodeArea (**CodeAreaDemoApp**). Also, a small example provides a standalone rich text editor, see **RichEditorDemoApp**.
>> 
>> Because it's an incubating module, please focus on the public APIs rather than implementation.  There **will be** changes to the implementation once/if the module is promoted to the core by popular demand.  The goal of the incubator is to let the app developers try the new feature out. 
>> 
>> **References**
>> 
>> - Proposal: https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
>> - Discussion points: https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextAreaDiscussion.md
>> - API specification (javadoc): https://cr.openjdk.org/~angorya/RichTextArea/javadoc
>> - RichTextArea RFE: https://bugs.openjdk.org/browse/JDK-8301121
>> - Behavior doc: https://github.com/andy-goryachev-oracle/jfx/blob/8301121.RichTextArea/doc-files/behavior/RichTextAreaBehavior.md
>> - CSS Reference: https://cr.openjdk.org/~angorya/RichTextArea/javadoc/javafx.graphics/javafx/scene/doc-files/cssref.html
>> - InputMap (v3): https://github.com/andy-goryachev-oracle/Test/blob/main/doc/InputMap/InputMapV3.md
>> - Previous Draft PR: https://github.com/openjdk/jfx/pull/1374
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   whitespace

A few more minor suggestions. I shall test the sample apps and provide any feedback.

modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/D.java line 1:

> 1: package com.sun.jfx.incubator.scene.control.richtext.util;

Missing copyright header.

modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/D.java line 12:

> 10:         StringBuilder sb = new StringBuilder();
> 11:         for (Object x : a) {
> 12:             if (sb.length() > 0) {

suggestion: `if (!sb.empty())`

modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/ListenerHelper.java line 85:

> 83:     public static ListenerHelper get(SkinBase<?> skin) {
> 84:         return accessor.apply(skin);
> 85:     }

I think ideally, a get method should not do any processing but just return the desired value/object.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1524#pullrequestreview-2472714954
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1865860373
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1865879649
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1866135904