RFR: 8301121: RichTextArea Control (Incubator) [v52]

Andy Goryachev angorya at openjdk.org
Tue Dec 3 16:45:48 UTC 2024


On Tue, 3 Dec 2024 15:05:54 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 72 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - since 24
>>  - review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - hide skin input map
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - ... and 62 more: https://git.openjdk.org/jfx/compare/67eed6d8...4b27b891
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java line 1193:
> 
>> 1191:      * @see RichTextArea.Tags#CUT
>> 1192:      */
>> 1193:     public void cut() {
> 
> We have `copy(DataFormat)` and `paste(DataFormat)`. Would it make sense to also have `cut(DataFormat)`?

I would say there is no use case for `cut(DataFormat)`.  The copy and paste are used for "Copy Special..." and "Paste Special..." items in the context menu - see `RichTextAreaDemoPane:416`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1868060684


More information about the openjfx-dev mailing list