RFR: 8301121: RichTextArea Control (Incubator) [v47]

[Kevin Rushforth]

On Wed, 20 Nov 2024 23:56:32 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 66 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - hide skin input map
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - save as
>>  - removed function handler
>>  - removed add handler last
>>  - use focus traversal api
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7
>
> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java line 163:
> 
>> 161:      * @return the KeyBinding, or null
>> 162:      */
>> 163:     public static KeyBinding option(KeyCode code) {
> 
> In the documentation of `alt` you say that it is equivalent to `option` on macOS. So what we have is an `alt` method that works on all platforms and an `option` method that does the same thing as `alt` on macOS and returns `null` on other platforms? This seems like an odd situation. Do we really need the `option` method?

If you intend to keep this method, please add a comment that, on macOS, it is equivalent to calling `alt`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1868260269