RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v8]
Lukasz Kostyra
lkostyra at openjdk.org
Wed Dec 4 14:07:49 UTC 2024
On Tue, 3 Dec 2024 22:59:20 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> The bug happened when setting only width or height (not both) on a Stage that was oriented by the view size.
>>
>> The fix just uses the previous value for width/height if not set.
>>
>> The test class is designed to accept more test cases in the "mixed sizing" scenarios.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision:
>
> - Move it to a Robot test
> - Fix test to fail without the fix
Test works well and now it indeed fails when the fix is not there. LGTM
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1654#pullrequestreview-2478777646
More information about the openjfx-dev
mailing list