RFR: 8288893: Popup and its subclasses cannot input text from InputMethod [v3]

Andy Goryachev angorya at openjdk.org
Wed Dec 4 15:38:55 UTC 2024


On Wed, 4 Dec 2024 14:39:52 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 578:
>> 
>>> 576:             // still monitoring owner events.
>>> 577:             Scene scene = getScene();
>>> 578:             SceneHelper.getInputMethodStateManager(scene).removeScene(scene);
>> 
>> `Window.scene` is a property, so theoretically the application code can set a new Scene at any moment.  How will that be handled?
>
> In a PopupWindow the scene there is no API to set the scene. It's managed internally by the system and should not change over the lifetime of the popup window. I will take a second look at that code next week to verify.

One can extend `PopupWindow` and call the protected `setScene()`, so this is a valid scenario, I think.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1634#discussion_r1869804903


More information about the openjfx-dev mailing list