RFR: 8344114: Remove obsolete permission check methods from Font classes

[Kevin Rushforth]

On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> This PR removes obsolete permission check methods and fields from Font-related classes.
> 
> Verified the changes on Windows, did not see any regressions.

I spotted what looks like a bug in `loadEmbeddedFont`. The rest looks good.

modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java line 1375:

> 1373:         if (FontFileWriter.hasTempPermission()) {
> 1374:             return loadEmbeddedFont0(name, fontStream, size, register, loadAll);
> 1375:         }

This test always returns true today, so it looks like you removed the code path that was in use. Unless I'm missing something, I think that you should restore the "return loadEmbeddedFont0" call and remove everything else below this point from this method.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1659#pullrequestreview-2485392856
PR Review Comment: https://git.openjdk.org/jfx/pull/1659#discussion_r1873691186