RFR: 8344111: Remove obsolete permission check methods from javafx.graphics

[Lukasz Kostyra]

On Fri, 6 Dec 2024 18:01:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java line 597:
>> 
>>> 595:                 // event handler.
>>> 596:                 // If not notify the stageListener to reset fullscreen to false.
>>> 597:                 if (!fullScreenFromUserEvent) {
>> 
>> is this correct?
>> 
>> do I understand that the effective value for isTrusted is true, which makes the condition that the if tests false, so the (new) lines 598-599 would never execute.
>
> Good catch. You are right. The entire block should be removed. As it is, this will incorrectly limit the set of keys that can be accessed in full-screen mode.
> 
> This might be why Lukasz thought that `fullScreenFromUserEvent` was still needed.

Indeed good catch. Monday brain now wonders what Friday brain was thinking 😉

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1658#discussion_r1875919220