RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

Marius Hanl mhanl at openjdk.org
Tue Dec 10 22:31:47 UTC 2024


On Tue, 10 Dec 2024 22:03:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Yes, IntelliJ actually gave me the hint.
>> `isVisible` can only be `false`, when a `fixedCellSize` is set. So the else branch can only ever be executed when `fixedCellSize > 0`
>
> it's hard to tell (for me): there are just too many conditions: isColumnParticallyOrFullVisible(), if parent == null...

It will be much better after https://github.com/openjdk/jfx/pull/1644 :)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1645#discussion_r1879003014


More information about the openjfx-dev mailing list