RFR: 8343398: Add reducedData preference [v4]

Michael Strauß mstrauss at openjdk.org
Wed Dec 11 19:23:07 UTC 2024


On Wed, 11 Dec 2024 18:33:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into feature/reduced-data
>>  - refactor macOS PlatformSupport
>>  - javadoc change
>>  - error message tweak
>>  - add macOS implementation
>>  - add linux implementation
>>  - Implementation of reducedData
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line 190:
> 
>> 188:     {
>> 189:         // unblock main thread. Glass is started at this point.
>> 190:         self->platformSupport = [[PlatformSupport alloc] initWithEnv:env application:jApplication];
> 
> should we check for failure here?  (alloc)

We never do that in obj-c native code, so this probably wouldn't be the place to start. In any case, a failure at this point wouldn't lead to a crash, as the only access of `platformSupport` checks for `nil`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1656#discussion_r1880762924


More information about the openjfx-dev mailing list