RFR: 8301121: RichTextArea Control (Incubator) [v61]
Andy Goryachev
angorya at openjdk.org
Thu Dec 12 22:34:54 UTC 2024
On Thu, 12 Dec 2024 19:19:00 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 83 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>> - legal
>> - unicode license
>> - add handler
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>> - clamp
>> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>> - review comments
>> - review comments
>> - ... and 73 more: https://git.openjdk.org/jfx/compare/b76c05b9...e5814b21
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java line 841:
>
>> 839: * @throws UnsupportedOperationException if the model is not {@link #isWritable() writable}
>> 840: */
>> 841: public final TextPos[] undo(StyleResolver resolver) {
>
> Should this be a List?
no, the two-element array [start, end] should be sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882977311
More information about the openjfx-dev
mailing list