RFR: 8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed

[Kevin Rushforth]

On Wed, 27 Nov 2024 19:27:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Add the `--sun-misc-unsafe-memory-access=allow` flag until [JDK-8334137](https://bugs.openjdk.org/browse/JDK-8334137) is fixed to avoid warnings when running tests (automated and manual) with JDK 24.
> 
> I've tested this using a boot JDK of JDK 22.0.2, JDK 23 (the boot JDK we use in production), and in our CI with the latest promoted build of JDK 24, which now warns by default when a deprecated method in `sun.misc.Unsafe` is called.
> 
> Without this fix, we see a warning when running our automated or manual tests with JDK 24. With this fix, we see no warnings.

build.gradle line 771:

> 769: 
> 770:             ext.jdk23OrLater = jdkVersionInfo.feature() >= 23
> 771:             ext.jdk24OrLater = jdkVersionInfo.feature() >= 24

We really only need to add `--sun-misc-unsafe-memory-access=allow` when running with JDK 24 or later ("allow" is the default in JDK 23). I want to do initial testing on JDK 23 with this flag, but will likely change all of the checks to `jdk24OrLater` for the final version, in which case we won't need the `jdk23OrLater` flag.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1650#discussion_r1861162515