RFR: 8343398: Add reducedData preference [v7]

[Kevin Rushforth]

On Wed, 18 Dec 2024 20:52:59 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> The `reducedData` preference instructs applications to minimize internet traffic, as users might be on a metered network or a limited data plan.
>> 
>> This corresponds to the following OS settings:
>> 
>> Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered connection
>> macOS: Settings -> Network -> Ethernet/WiFi -> Network Settings -> Low data mode
>> Ubuntu: Settings -> Network -> Wired/WiFi -> Metered connection
>> 
>> Change notifications work consistently on Windows and macOS. On my Ubuntu 24 system, the GIO `network-changed` signal is not sent when I only toggle the "metered connection" flag in network settings (and there's no signal specifically for low-data mode). The new value is only picked up when the connection changes by coming offline or going online.
>
> Michael Strauß has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - typo
>  - store the app delegate reference in MacApplication

I'll take a closer look later, but the changes to solve the problem with GlassApplication look good to me.

I'll also fire off another headful test run and report the results.

modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line 995:

> 993:     NSAutoreleasePool *glasspool = [[NSAutoreleasePool alloc] init];
> 994:     {
> 995:         GlassApplication* glass = (GlassApplication*)appDelegate;

This looks like a clean split to me.

modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line 1026:

> 1024: 
> 1025:     if (appDelegate) {
> 1026:         [(GlassApplication*)appDelegate release];

This is needed because you moved the allocation of GlassApplication outside (before) the auto-release pool in runLoop, so looks good.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1656#pullrequestreview-2512892606
PR Review Comment: https://git.openjdk.org/jfx/pull/1656#discussion_r1890855088
PR Review Comment: https://git.openjdk.org/jfx/pull/1656#discussion_r1890855283