RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

[Ambarish Rapte]

On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès <lbourges at openjdk.org> wrote:

>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed copyright years of modified files + fixed comments in DMarlinPrismUtils

tests/system/src/test/java/test/com/sun/marlin/Scale0Test.java line 253:

> 251:     }
> 252: 
> 253: }

I had few comments about the test like:
1. MyApp class can be removed
2. if (button instanceof Labeled) can be removed
3. preparePane() method could be shortened.
4. Variables leftPane and slider could be local
5. final keyword could be removed from some local variables.
6. Rename the test file and test function.

I made these changes locally and sharing the file as attached.

[ScaleX0Test.zip](https://github.com/openjdk/jfx/files/14123536/ScaleX0Test.zip)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1348#discussion_r1474190840