RFR: 8320912: IME should commit on focus change

Andy Goryachev angorya at openjdk.org
Thu Feb 1 16:51:10 UTC 2024


On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox <mfox at openjdk.org> wrote:

> This is a Mac only bug. If the user was in the middle of IM text composition and clicked on a different node the partially composed text was left in the old node and the IM window wasn't dismissed. This PR implements the existing finishInputMethodComposition call so it can commit the text and dismiss the IM window before focus moves away from the node where composition was taking place.
> 
> This PR changes the implementation of `unmarkText` to match what we want and what Apple says it should do ("The text view should accept the marked text as if it had been inserted normally"). With that said I haven't found an IME that calls this routine.

You are right - I should have checked a native app.  It works as expected then.

Thank you for fixing this bug!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1356#pullrequestreview-1856993847


More information about the openjfx-dev mailing list