RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

Robert Lichtenberger rlichten at openjdk.org
Fri Feb 2 10:42:06 UTC 2024


On Fri, 2 Feb 2024 08:44:45 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>>> can this also be moved out? `cell.updateTableRow(tableRow);`
>> 
>> I don't think so. Since tableRow gets an updated index above, the cell's style could change (e.g. odd / even styling).
>
> Well, the `tableRow` is still set (but before the loop), we just update the index in this loop. 
> It looks like setting the table row in this loop is not needed, just once above. I also don't see that `setTableRow` has any side effects. So maybe worth a try.

You're right. I tried it out and it seems to work.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1358#discussion_r1475877054


More information about the openjfx-dev mailing list