RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

John Hendrikx jhendrikx at openjdk.org
Tue Feb 6 00:04:34 UTC 2024


On Mon, 5 Feb 2024 17:19:35 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> > I think `getClasses` is fine. My second choice would be `getClassNames`.
> 
> Perhaps it might be `getStyleClasses()` to parallel one in `Node`? (I don't know why Node's method is called `getStyleClass` (singular) when it clearly returns multiple Strings.)

The problem with that choice is that it would need 2 passes, because there already is a method named like that:

    List<String> getStyleClasses()

We'd first need to get rid of it, then replace it with `Set<String> getStyleClasses()`.

Keeping it as a `List` I would not recommend, since selectors don't keep duplicates, and don't keep the order (they never did).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1928218068


More information about the openjfx-dev mailing list