RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

Karthik P K kpk at openjdk.org
Tue Feb 6 11:43:00 UTC 2024


On Mon, 29 Jan 2024 09:09:40 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed test package
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/ArrayCacheDouble.java line 168:
> 
>> 166:                 if (DO_CLEAN_DIRTY && (toIndex != 0)) {
>> 167:                     // clean-up array of dirty part[fromIndex; toIndex[
>> 168:                     fill(array, fromIndex, toIndex, /*(double)*/ 0.0);
> 
> Do you think /*(double)*/ will be helpful? In my opinion, it is not required.

@bourgesl are planning to remove these comments? Wanted to check since the comment was resolved without change.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1348#discussion_r1479636490


More information about the openjfx-dev mailing list