RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

Andy Goryachev angorya at openjdk.org
Tue Feb 6 18:12:00 UTC 2024


On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>> 
>> Added checks for RTL orientation of nodes and  fixed the issue in `getHitInfo()` to calculate correct hit test values.
>> 
>> Added system tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Inline node issue fix

Fails with "Emojis" data set (magenta line indicates where):

![Screenshot 2024-02-06 at 10 07 45](https://github.com/openjdk/jfx/assets/107069028/357628f5-cf08-4694-a2a6-ac4ed1532126)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1930497240


More information about the openjfx-dev mailing list