RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v4]

Kevin Rushforth kcr at openjdk.org
Wed Feb 7 00:08:59 UTC 2024


On Tue, 6 Feb 2024 21:35:12 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> The SimpleSelector and CompoundSelector classes are public classes in an exported package, javafx.css, but they are not intended to be used by applications. They are implementation details. They cannot be constructed directly and no other JavaFX API accepts or returns a SimpleSelector or CompoundSelector.
>> 
>> We should deprecate them for removal so we can move them to a non-exported package, removing them from the public API.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Resolve review comments

So we can add `getStyleClassesSet` to the list of possible method names. I think the word "class" should be in the name of the method, which excludes `getStyles` and `getStyleNames`, leaving the following:


getStyleClassNames
getClasses
getClassNames
getStyleClassesSet


Any of them seem OK to me. I don't have a strong preference.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1930988290


More information about the openjfx-dev mailing list