RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

Marius Hanl mhanl at openjdk.org
Wed Feb 7 08:54:58 UTC 2024


On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger <rlichten at openjdk.org> wrote:

> The PR simply moves column and view-updates outside the loop. Since the column or view never changes within the for-loop it is not necessary to call these again and again.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 670:

> 668:             cell.updateTableRow(tableRow);
> 669:             cell.updateIndex(row);
> 670: 

we could also check if we need/can call `tableRow.applyCss();` just only one time (below) (e.g. at first?),
May works and improve performance, or may not work

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1358#discussion_r1481111741


More information about the openjfx-dev mailing list